[SPARK-51269][SQL] SQLConf should manage the default value for avro compression level #50021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @yaooqinn cc @dongjoon-hyun @LuciferYang |
There was a problem hiding this comment.
Could you elaborate on this a little more, @beliefer ?
If developers use the config item in any other code path, there is no guarantee for the default value.
|
Sorry, I don't quite understand what are we going to change. |
Updated. |
Please take a look again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to let SQLConf manage the default value for avro compression level.
Why are the changes needed?
Currently, the default value of
spark.sql.avro.deflate.levelis -1. But it managed with the enumAvroCompressionCodec.The document of the config item
spark.sql.avro.deflate.levelcontains the descriptionThe default value is -1 which corresponds to 6 level in the current implementation.So the users get the knowledge that it has the default value -1.If some developer use the config item in mistake, there is no guarantee for the default value. And then causes some unpredictable behavior and make users confused.
I think we should keep the default value within
SQLConfin safety.Some other config item has the same confusion,
spark.sql.avro.xz.levelandspark.sql.avro.zstandard.level.Does this PR introduce any user-facing change?
'No'.
New feature.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
'No'.