Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49677][SS] Ensure that changelog files are written on commit and forceSnapshot flag is also reset #48125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anishshri-db
Copy link
Contributor

@anishshri-db anishshri-db commented Sep 16, 2024

What changes were proposed in this pull request?

Ensure that changelog files are written on commit and forceSnapshot flag is also reset

Why are the changes needed?

Without these changes, we are not writing the changelog files per batch and we are also trying to upload full snapshot each time since the flag is not being reset correctly

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added unit tests

Before:

[info] Run completed in 3 seconds, 438 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 0, failed 1, canceled 0, ignored 0, pending 0
[info] *** 1 TEST FAILED ***

After:

[info] Run completed in 4 seconds, 155 milliseconds.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Was this patch authored or co-authored using generative AI tooling?

No

Copy link
Contributor

@ericm-db ericm-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need to change anything in setInitialCfInfo?

@anishshri-db
Copy link
Contributor Author

Do we not need to change anything in setInitialCfInfo?

Don't think so. We need to retain the map contents/maxId across newer versions. So only resetting forceSnapshot should be sufficient I think

@anishshri-db
Copy link
Contributor Author

@HeartSaVioR - PTAL, thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants