Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 page with instuctions for EOL docs #552

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

yaooqinn
Copy link
Member

Before

image

After

image

@yaooqinn yaooqinn merged commit 55912b0 into apache:asf-site Aug 28, 2024
1 check passed
@yaooqinn yaooqinn deleted the 404 branch August 28, 2024 05:36
@yaooqinn
Copy link
Member Author

Merged to asf-site. Thank you @HyukjinKwon

@yaooqinn
Copy link
Member Author

Excuse me for committing a followup w/o review. This patch is required by Apache Web Servers. And I needed to test via the Apache server w/ the patch deployed.

The 404 now works both online and on localhost

FYI, https://spark.apache.org/docs/3.1.1/api/python/reference/api/pyspark.sql.DataFrame.dropDuplicates.html

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, late LGTM. Thank you!

@yaooqinn
Copy link
Member Author

Thank you @dongjoon-hyun

@allisonwang-db
Copy link
Contributor

Thanks for adding this! This looks much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants