chore: updates actions to improves CI times and resource management. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading to setup-go@v4 enables caching for deps and also allowing to build vendor folder and pass it into docker image saves dependency pull inside the docker image but also uses the dependency caching.
jcchavezs
commented
Aug 10, 2023
| uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: 1.18 | ||
| - name: Pull deps for tools/go-agent |
There was a problem hiding this comment.
Small trick here, we pull deps for tools/go-agent which internally uses the dep cache and then package it into vendor module which allows to be reused in the docker build.
jcchavezs
commented
Aug 10, 2023
| @@ -34,7 +34,7 @@ jobs: | |||
| timeout-minutes: 60 | |||
| steps: | |||
| - name: Set up Go 1.18 | |||
| uses: actions/setup-go@v2 | |||
| uses: actions/setup-go@v4 | |||
There was a problem hiding this comment.
Takes advantage of deps caching.
|
I wonder how to run the kratosv2 test in local. |
Sorry for the late reply. It should same as the CI, you need to build the plugin test tool and run the script. |
mrproliu
reviewed
Aug 16, 2023
| @@ -3,24 +3,98 @@ module github.com/apache/skywalking-go/tools/go-agent | |||
| go 1.18 | |||
|
|
|||
| require ( | |||
| github.com/apache/skywalking-go/plugins/core v0.0.0-20230809094220-b3b15735a623 | |||
There was a problem hiding this comment.
We are already using go workspace, why do we need to import package here?
|
Closing. No update for months. When you are ready, open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to setup-go@v4 enables caching for deps and also allowing to build vendor folder and pass it into docker image saves dependency pull inside the docker image but also uses the dependency caching.
A next step would be to use build cache to cache test execution for go tests.