Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin grpc Unary #88

Merged
merged 1 commit into from
Aug 8, 2023
Merged

plugin grpc Unary #88

merged 1 commit into from
Aug 8, 2023

Conversation

Alipebt
Copy link
Contributor

@Alipebt Alipebt commented Aug 5, 2023

No description provided.

@wu-sheng wu-sheng added this to the 0.3.0 milestone Aug 5, 2023
@wu-sheng wu-sheng added the plugin label Aug 5, 2023
@wu-sheng wu-sheng requested a review from mrproliu August 5, 2023 08:47
@wu-sheng
Copy link
Member

wu-sheng commented Aug 5, 2023

You need to update docs of supported list accordingly.

@wu-sheng
Copy link
Member

wu-sheng commented Aug 5, 2023

And it seems you don't add your new test in the CI files, therefore, your cases haven't been verified by CI.

mrproliu
mrproliu reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the steaming related interceptor you have also commit? Please remove it and submit in other PR.

docs/en/agent/support-plugins.md Outdated Show resolved Hide resolved
plugins/grpc/client_recvmsg_interceptor.go Outdated Show resolved Hide resolved
plugins/grpc/client_sendmsg_interceptor.go Outdated Show resolved Hide resolved
plugins/grpc/client_sendmsg_interceptor.go Outdated Show resolved Hide resolved
plugins/grpc/client_unary_interceptor.go Outdated Show resolved Hide resolved
plugins/grpc/client_unary_interceptor.go Outdated Show resolved Hide resolved
plugins/grpc/server_unary_interceptor.go Show resolved Hide resolved
mrproliu
mrproliu reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@mrproliu mrproliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CHANGES.md and support plugin list. Also, the CI seem failure, please fix.

go.mod Outdated Show resolved Hide resolved
plugins/grpc/go.mod Outdated Show resolved Hide resolved
plugins/grpc/server_handleStream_interceptor.go Show resolved Hide resolved
test/plugins/scenarios/grpc/go.mod Outdated Show resolved Hide resolved
mrproliu
mrproliu previously approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the plugin test.

@Alipebt Alipebt force-pushed the main branch 3 times, most recently from ecc0375 to a30324b Compare August 7, 2023 11:32
@Alipebt
plugin grpc Unary
0cf19fb 
Signed-off-by: Alipebt <[email protected]>
@mrproliu mrproliu merged commit fd87ffe into apache:main Aug 8, 2023
28 checks passed
@Alipebt Alipebt mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrproliu mrproliu mrproliu approved these changes

Assignees
No one assigned
Labels
plugin
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Alipebt @wu-sheng @mrproliu