Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev measure aggregate function #528

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Dev measure aggregate function #528

wants to merge 37 commits into from

Conversation

StLeoX
Copy link
Contributor

@StLeoX StLeoX commented Sep 5, 2024

Add several functions

  • If this is non-trivial feature, paste the links/URLs to the design doc.
  • Update the documentation to include this new feature.
  • Tests(including UT, IT, E2E) are added to verify the new feature.
  • If it's UI related, attach the screenshots below.

Here are new added functions:

  • max
  • count
  • sum
  • percent
  • rate

StLeoX and others added 30 commits June 28, 2024 16:01
@StLeoX
[API] MeasureAggregateFunctionService Support
00b2bdb
@StLeoX
fix check
38aec7f
@wu-sheng
Merge branch 'main' into dev_measure_aggregate_function
4c94a7c
@StLeoX
use MeasureAggregate enum
ad3b14a
@StLeoX
Merge branch 'main' into dev_measure_aggregate_function
d456b4f
@hanahmily
Merge branch 'main' into dev_measure_aggregate_function
acfe475
@StLeoX
add PERCENTILE enum for MEASURE_AGGREGATE
e05a97b
@StLeoX
add comments for MeasureAggregate enum
e1b7e98
@StLeoX
Merge branch 'main' into dev_measure_aggregate_function
b94f21b
@StLeoX
fix enum name error in FieldSpec
7c9d27f
@StLeoX
a
11ccee1
@StLeoX
fix wrong enum name in FieldSpec
cfc3811
@StLeoX
Supports measure aggregate function avg and min, and test cases.
31763db
@StLeoX
Merge remote-tracking branch 'origin/dev_measure_aggregate_function' …
13c1180 
…into dev_measure_aggregate_function
@StLeoX
Revert "a"
98076ff 
This reverts commit 11ccee1.
@StLeoX
Merge branch 'main' into dev_measure_aggregate_function
515b3f9 
# Conflicts:
#	api/proto/banyandb/database/v1/schema.proto
#	docs/api-reference.md
@StLeoX
fix Merge error
deefc6e
@StLeoX
remove struct MAFArgument[T]
420c4ef
@StLeoX
rename Function
ac23ca7
@StLeoX
simplify Input and Arguments
2b5ca52
@StLeoX
add NewArguments
f6b6fe6
@StLeoX
supports Max
1098f25
@StLeoX
supports Count
aa722cd
@StLeoX
supports Sum
337e2fc
@StLeoX
supports Percent
7de26d8
@StLeoX
supports Rate
fde584c
@StLeoX
add comments
792dc1b
@hanahmily
Merge branch 'main' into dev_measure_aggregate_function
61eb634
@StLeoX
Merge remote-tracking branch 'origin/dev_measure_aggregate_function' …
6fa5573 
…into dev_measure_aggregate_function
@StLeoX
fix unit test
806b6d9
@wu-sheng
Copy link
Member

wu-sheng commented Sep 5, 2024

Please rebases the commits to avoid so long commit logs.

hanahmily
hanahmily requested changes Sep 8, 2024
View reviewed changes
banyand/measure/aggregate/avg.go Outdated Show resolved Hide resolved
banyand/measure/aggregate/aggregate_function.go Show resolved Hide resolved
hanahmily
hanahmily requested changes Sep 10, 2024
View reviewed changes
banyand/measure/aggregate/aggregate_function.go Show resolved Hide resolved
banyand/measure/aggregate/avg.go Outdated Show resolved Hide resolved
@StLeoX
Copy link
Contributor Author

StLeoX commented Sep 21, 2024

Benchmark loop-unrolling

The benchmark code is here.

On my machine, the result is:
image

We can see that, with the round increasing, the efficiency difference is decreasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@hanahmily hanahmily Awaiting requested review from hanahmily

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StLeoX @wu-sheng @hanahmily