-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ARM64 build binary and images #514
Conversation
- name: Build OSX binaries | ||
run: | | ||
GOOS=darwin GOARCH=arm64 make -C banyand banyand-server-static | ||
GOOS=darwin GOARCH=arm64 make -C bydbctl build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this AARM or ARM? The CI name seems a little tricky.
Currently, I just add I wonder if we really need something like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
===========================================
+ Coverage 41.16% 51.52% +10.35%
===========================================
Files 157 157
Lines 18963 18963
===========================================
+ Hits 7807 9771 +1964
+ Misses 10515 8415 -2100
- Partials 641 777 +136 ☔ View full report in Codecov by Sentry. |
darwin(aarm), we don't need this for official release. But we need Linux ARM as that, same for ctl. The issue is referring these two things. |
Shall we consider goreleaser to build binaries and docker images? |
We could consider this in a separate thread? |
@hanahmily Please confirm whether this is the scope of this PR. Because in the end, we will need 3 images(linux intel, linux and, dawin) in GitHub image repo and first two in the DockerHub. |
The build system needs to be improved to support building multi-platform binaries, which is more complicated than I initially thought. I will address this issue. @StLeoX, I will leave you to your ospp project. |
Fine |
Support ARM64 build binary and images