-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple roles for banyand #305
Conversation
Signed-off-by: Gao Hongtao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 39.93% 39.84% -0.09%
==========================================
Files 100 101 +1
Lines 10870 10894 +24
==========================================
Hits 4341 4341
- Misses 6111 6135 +24
Partials 418 418
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Gao Hongtao <[email protected]>
// under the License. | ||
|
||
// Package embeddedetcd implements an embedded etcd server. | ||
package embeddedetcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lujiajing1126 I've already separated the embed server from the schema registry. Could you update your local repo in case there are some conflicts?
So, with this spliting, banyandb still is able to run in stand alone mode? But as support to set an external etcd cluster? |
It has the capacity to run as a standalone with embed etcd without external ones. |
I mean, do we expect am external etcd in cluster? Or still running internally? |
Banyand has been updated to run in multiple roles, but it cannot work in cluster mode. There are still several pending tasks to be completed.
As a reviewer, you should focus on the document that outlines the fundamental behavior of the server with multiple roles in Banyand.
CHANGES
log.