Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push the max int as limitation #289

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Push the max int as limitation #289

merged 3 commits into from
Jun 28, 2023

Conversation

hanahmily
Copy link
Contributor

@hanahmily hanahmily added the bug Something isn't working label Jun 28, 2023
@hanahmily hanahmily added this to the 0.4.0 milestone Jun 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #289 (8a81256) into main (0875e0a) will decrease coverage by 0.72%.
The diff coverage is 10.61%.

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   44.90%   44.18%   -0.72%     
==========================================
  Files          93       93              
  Lines        9632     9804     +172     
==========================================
+ Hits         4325     4332       +7     
- Misses       4893     5054     +161     
- Partials      414      418       +4     
Impacted Files Coverage Δ
banyand/measure/measure_write.go 3.87% <0.00%> (ø)
banyand/stream/stream_write.go 13.76% <0.00%> (-0.13%) ⬇️
banyand/tsdb/buffer.go 82.58% <0.00%> (-2.95%) ⬇️
banyand/tsdb/scope.go 0.00% <0.00%> (ø)
banyand/tsdb/series_seek.go 0.00% <ø> (ø)
banyand/tsdb/series_seek_sort.go 0.00% <0.00%> (ø)
banyand/tsdb/series_write.go 49.54% <0.00%> (-4.46%) ⬇️
banyand/tsdb/tsdb.go 53.37% <ø> (ø)
pkg/query/logical/measure/measure_analyzer.go 0.00% <0.00%> (ø)
...ry/logical/measure/measure_plan_indexscan_local.go 0.00% <0.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lujiajing1126 lujiajing1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lujiajing1126 lujiajing1126 merged commit 1f2e8f4 into main Jun 28, 2023
@lujiajing1126 lujiajing1126 deleted the measure-push-limit branch June 28, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants