Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve granularity of index in measure by leveling up from data point to series #286

Merged
merged 5 commits into from
Jun 27, 2023

Conversation

hanahmily
Copy link
Contributor

Signed-off-by: Gao Hongtao <[email protected]>
@hanahmily hanahmily added the enhancement New feature or request label Jun 26, 2023
@hanahmily hanahmily added this to the 0.4.0 milestone Jun 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #286 (f60e6e5) into main (0875e0a) will decrease coverage by 0.68%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   44.90%   44.22%   -0.68%     
==========================================
  Files          93       93              
  Lines        9632     9799     +167     
==========================================
+ Hits         4325     4334       +9     
- Misses       4893     5047     +154     
- Partials      414      418       +4     
Impacted Files Coverage Δ
banyand/measure/measure_write.go 3.87% <0.00%> (ø)
banyand/stream/stream_write.go 13.76% <0.00%> (-0.13%) ⬇️
banyand/tsdb/buffer.go 83.87% <0.00%> (-1.66%) ⬇️
banyand/tsdb/scope.go 0.00% <0.00%> (ø)
banyand/tsdb/series_seek.go 0.00% <ø> (ø)
banyand/tsdb/series_seek_sort.go 0.00% <0.00%> (ø)
banyand/tsdb/series_write.go 49.54% <0.00%> (-4.46%) ⬇️
banyand/tsdb/tsdb.go 53.37% <ø> (ø)
...ry/logical/measure/measure_plan_indexscan_local.go 0.00% <0.00%> (ø)
banyand/tsdb/seriesdb.go 35.88% <7.53%> (-12.40%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

18M ./measure-default/shard-0/series
245M ./measure-default/shard-0
245M ./measure-default
391M .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes have reduced the size by ~200MB. @lujiajing1126

@hanahmily
Copy link
Contributor Author

Some e2e cases failed. I'm diving into them.

wu-sheng
wu-sheng previously approved these changes Jun 26, 2023
@wu-sheng wu-sheng merged commit 69ad27b into main Jun 27, 2023
@hanahmily hanahmily deleted the series-index branch June 27, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants