Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce startup probe to deployments #24

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ dependencies:
repository: oci://registry-1.docker.io/bitnamicharts
version: 9.14.3
digest: sha256:31aacd1ae011febfa82522a1777fd2f36a52529bea2e343bacb0060c51068906
generated: "2024-03-01T09:44:38.864211193+08:00"
generated: "2024-09-14T06:34:19.861488669Z"
15 changes: 14 additions & 1 deletion chart/templates/liaison_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,20 @@ spec:
timeoutSeconds: {{ .Values.cluster.liaison.livenessProbe.timeoutSeconds }}
successThreshold: {{ .Values.cluster.liaison.livenessProbe.successThreshold }}
failureThreshold: {{ .Values.cluster.liaison.livenessProbe.failureThreshold }}

startupProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.cluster.liaison.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.cluster.liaison.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.cluster.liaison.startupProbe.periodSeconds }}
timeoutSeconds: {{ .Values.cluster.liaison.startupProbe.timeoutSeconds }}
successThreshold: {{ .Values.cluster.liaison.startupProbe.successThreshold }}
failureThreshold: {{ .Values.cluster.liaison.startupProbe.failureThreshold }}
{{- if.Values.cluster.liaison.resources }}
resources:
{{- if.Values.cluster.liaison.resources.requests }}
Expand Down
2 changes: 2 additions & 0 deletions chart/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ spec:
{{- end }}
{{- end }}

{{- if .Values.standalone.tls -}}
{{- if .Values.standalone.tls.grpcSecretName }}
- mountPath: /etc/tls/{{ .Values.standalone.tls.grpcSecretName }}
name: {{ .Values.standalone.tls.grpcSecretName }}-volume
Expand All @@ -169,6 +170,7 @@ spec:
- mountPath: /etc/tls/{{ .Values.standalone.tls.httpSecretName }}
name: {{ .Values.standalone.tls.httpSecretName }}-volume
{{- end }}
{{- end -}}
{{- end }}

{{- if .Values.standalone.tls }}
Expand Down
14 changes: 14 additions & 0 deletions chart/templates/ui_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,20 @@ spec:
timeoutSeconds: {{ .Values.cluster.ui.standalone.livenessProbe.timeoutSeconds }}
successThreshold: {{ .Values.cluster.ui.standalone.livenessProbe.successThreshold }}
failureThreshold: {{ .Values.cluster.ui.standalone.livenessProbe.failureThreshold }}
startupProbe:
httpGet:
path: /api/healthz
port: 17913
{{- if .Values.cluster.ui.standalone.tls }}
scheme: HTTPS
{{- else }}
scheme: HTTP
{{- end }}
initialDelaySeconds: {{ .Values.cluster.ui.standalone.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.cluster.ui.standalone.startupProbe.periodSeconds }}
timeoutSeconds: {{ .Values.cluster.ui.standalone.startupProbe.timeoutSeconds }}
successThreshold: {{ .Values.cluster.ui.standalone.startupProbe.successThreshold }}
failureThreshold: {{ .Values.cluster.ui.standalone.startupProbe.failureThreshold }}

{{- if.Values.cluster.ui.standalone.resources }}
resources:
Expand Down
14 changes: 14 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,13 @@ cluster:
successThreshold: 1
failureThreshold: 5

startupProbe:
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

data:
name: banyandb
replicas: 3
Expand Down Expand Up @@ -445,6 +452,13 @@ cluster:
successThreshold: 1
failureThreshold: 5

startupProbe:
initialDelaySeconds: 0
periodSeconds: 10
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

storage:
enabled: false
persistentVolumeClaims:
Expand Down
21 changes: 21 additions & 0 deletions test/e2e/values.cluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ cluster:
successThreshold: 1
failureThreshold: 60

startupProbe:
initialDelaySeconds: 0
periodSeconds: 5
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

data:
replicas: 1
podAnnotations:
Expand Down Expand Up @@ -233,6 +240,13 @@ cluster:
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

startupProbe:
initialDelaySeconds: 0
periodSeconds: 5
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60
ui:
# Available UI type:
# None: Disable UI
Expand Down Expand Up @@ -341,6 +355,13 @@ cluster:
successThreshold: 1
failureThreshold: 5

startupProbe:
initialDelaySeconds: 0
periodSeconds: 5
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

storage:
enabled: false
persistentVolumeClaims:
Expand Down
7 changes: 7 additions & 0 deletions test/e2e/values.standalone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,13 @@ standalone:
successThreshold: 1
failureThreshold: 60

startupProbe:
initialDelaySeconds: 0
periodSeconds: 5
timeoutSeconds: 5
successThreshold: 1
failureThreshold: 60

grpcSvc:
labels: {}
annotations: {}
Expand Down
Loading