[type:fix] configs import and export refactor #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moremind
requested changes
Dec 2, 2024
...ain/java/org/apache/shenyu/admin/service/configs/SelectorDataConfigsExportImportHandler.java
Outdated
Show resolved
Hide resolved
eye-gu
force-pushed
the
fix-5826
branch
3 times, most recently
from
d4e8545 to
72fc338
Compare
moremind
requested changes
Dec 9, 2024
| /** | ||
| * dict. | ||
| */ | ||
| Dict("dict.json", 5), |
There was a problem hiding this comment.
may include dict and plugin handler?
There was a problem hiding this comment.
Currently, it includes both of these
There was a problem hiding this comment.
I think you should add plugin handler
There was a problem hiding this comment.
The plugin handler is associated with the plugin
moremind
requested changes
Dec 13, 2024
| /** | ||
| * dict. | ||
| */ | ||
| Dict("dict.json", 5), |
There was a problem hiding this comment.
I think you should add plugin handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5826
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.