-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Firebird XA transaction support #34360
Conversation
…Definition and FirebirdXAConnectionWrapper
/* TODO: Fix the error with getting XAResource
assertThat(actual.getXAResource(), */ An issue was discovered in the current code when trying to retrieve the XAResource object via the actual.getXAResource() call. The problem is related to the fact that during the creation of the FBXAConnection object, the connection reference (connection) is not properly stored in the mc variable (which is supposed to hold a weak reference to the FBConnection). I described the problem to provide an understanding of the solution, in case I return to fix it, or perhaps some enthusiastic person will take it on |
...apache/shardingsphere/transaction/xa/jta/connection/dialect/FirebirdXAConnectionWrapper.java
Outdated
Show resolved
Hide resolved
6e7d0f7
to
dabcd6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.