Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Firebird XA transaction support #34360

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

makssent
Copy link
Contributor

Changes proposed in this pull request:

  • Added FirebirdXADataSourceDefinition
  • Added FirebirdXAConnectionWrapper

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@makssent
Copy link
Contributor Author

/* TODO: Fix the error with getting XAResource
assertThat(actual.getXAResource(), */

An issue was discovered in the current code when trying to retrieve the XAResource object via the actual.getXAResource() call. The problem is related to the fact that during the creation of the FBXAConnection object, the connection reference (connection) is not properly stored in the mc variable (which is supposed to hold a weak reference to the FBConnection).

I described the problem to provide an understanding of the solution, in case I return to fix it, or perhaps some enthusiastic person will take it on

@makssent makssent force-pushed the firebird_xa_transactions branch from 6e7d0f7 to dabcd6c Compare January 18, 2025 13:28
Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@terrymanu terrymanu added this to the 5.5.3 milestone Jan 19, 2025
@terrymanu terrymanu merged commit 94a4f13 into apache:master Jan 21, 2025
147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants