Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firebird classes to infra/common and jdbc POMs #33976

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

TedCraft
Copy link
Contributor

@TedCraft TedCraft commented Dec 9, 2024

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

  • Add module shardingsphere-infra-database-firebird to infra/common pom.xml
  • Add module shardingsphere-parser-sql-firebird to jdbc/pom.xml

I don't know how I missed this when I was testing firebird modules when creating the first pr, but without it SPILodaer doesn't load firebird classes at all.


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@terrymanu terrymanu added type: dependencies Pull requests that update a dependency file db: Firebird labels Dec 9, 2024
@terrymanu terrymanu added this to the 5.5.2 milestone Dec 9, 2024
@terrymanu terrymanu merged commit 9035f4c into apache:master Dec 9, 2024
147 checks passed
@TedCraft TedCraft deleted the dependencies-fix branch December 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
db: Firebird type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants