Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to TestContainers JDBC URL of Firebird #33953

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

makssent
Copy link
Contributor

@makssent makssent commented Dec 7, 2024

Fixes #33782.

Changes proposed in this pull request:

  • Add support to TestContainers JDBC URL of Firebird to the optional module

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@terrymanu terrymanu merged commit d3e9490 into apache:master Dec 7, 2024
146 of 147 checks passed
@TedCraft TedCraft deleted the test_containers branch December 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Firebird support to testcontainers database type
2 participants