Support System env value #29704
Closed
Support System env value #29704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| builder.append(line).append('\n'); | ||
| } | ||
| } | ||
| return builder.toString().getBytes(StandardCharsets.UTF_8); | ||
| } | ||
| } | ||
|
|
||
| private String replaceVariables(final String line) { | ||
| Pattern variablePattern = Pattern.compile("\\$\\{(.+?)\\}"); |
There was a problem hiding this comment.
- The regular expression
${(.+?)}appears to conflict with the syntax involved in the Groovy implementation of Row Value Expressions. Maybe replace it with#{(.+?)}? Refer to https://shardingsphere.apache.org/document/current/en/user-manual/common-config/builtin-algorithm/expr/ . - Or other grammar recognition?
- I added separate documentation in Add separate documentation for ShardingSphereDriver's URL configuration #29730, it seems good to add two separate implementation for
#{(.+?)}, a non-standard way of identifying environment variables. What do you think?
There was a problem hiding this comment.
- I should know where the conflict is going to be, but using
#{(.+?)}would be considered a comment, so my current approach may not work well.
|
Because this scheme conflicts with other configurations, I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29657.
Changes proposed in this pull request:
Support System env value.
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.