Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add classpath parser to support apollo config #24523

Closed
wants to merge 0 commits into from

Conversation

hyz1994121
Copy link

Fixes #24498 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@hyz1994121
Copy link
Author

is there anyone can help me review?

@zhaojinchao95
Copy link
Contributor

zhaojinchao95 commented Mar 14, 2023

is there anyone can help me review?

Hi, thank you for your pull request, And i think this function are provided, you can see ApolloDriverURLProvider.class

@@ -220,6 +220,10 @@
<groupId>com.ctrip.framework.apollo</groupId>
<artifactId>apollo-client</artifactId>
</dependency>


<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency irreplaceable?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my opinion is irreplaceable,maybe you guys have more idea. we can discuss

@hyz1994121
Copy link
Author

is there anyone can help me review?

Hi, thank you for your pull request, And i think this function are provided, you can see ApolloDriverURLProvider.class

nonono, in ApolloDriverURLProvider.class,we must set the all yaml file into my apollo,
in my suggesstion, we can only use some ${} for my config value, which means i could not change my apollo config, i just change the config yaml in my project, and in my company, we use some placeholder for some account or password, in some jar package, program can replace the real password to the placeholder. so i provide this parser for the real yaml file in project
and the placeholder in apollo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOR shardingsphere5.3 dynamic config suggestion
3 participants