Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi instances change status by properties #1425

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Conversation

qiuqi06
Copy link
Contributor

@qiuqi06 qiuqi06 commented Aug 25, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run go build go test go fmt go vet to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.
  • Never comment source code, delete it.
  • UT should has "context, subject, expected result" result as test case name, when you call t.Run().

@qiuqi06 qiuqi06 force-pushed the master branch 2 times, most recently from 4bec166 to 2929442 Compare August 26, 2023 03:57
datasource/etcd/ms.go Outdated Show resolved Hide resolved
datasource/etcd/ms.go Outdated Show resolved Hide resolved
server/resource/disco/instance_resource.go Outdated Show resolved Hide resolved
server/resource/disco/instance_resource.go Outdated Show resolved Hide resolved
datasource/ms.go Outdated Show resolved Hide resolved
server/service/disco/instance.go Outdated Show resolved Hide resolved
@little-cui little-cui merged commit 429da63 into apache:master Aug 26, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants