-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-314] Support optimized join on ST_HausdorffDistance #878
Merged
jiayuasu
merged 53 commits into
apache:master
from
iGN5117:develop_Nilesh_1.4.1_HausdorffDistance
Jun 30, 2023
Merged
Changes from 51 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
85ae113
Remove prebuild_index config from search plugin
iGN5117 8e829fe
Update compile the code documentation for sedona
iGN5117 4bcf99c
approximate float comparisons in python test cases
iGN5117 c7f6236
Update compile the code documentation for sedona
iGN5117 ceed7a4
Remove prebuild_index config from search plugin
iGN5117 15c6255
Revert "Update compile the code documentation for sedona"
iGN5117 471e281
Revert "Remove prebuild_index config from search plugin"
iGN5117 2a5a6d8
FIxed incorrect indentation
iGN5117 6e9883d
Addressed PR comments for documentation changes
iGN5117 e66895e
Merge branch 'master' of https://github.com/iGN5117/sedona into docum…
iGN5117 cf7e78d
Add ST_NumPoints
iGN5117 fc23fc9
Update available version to 1.4.1 in documentation
iGN5117 fea1daa
Merge branch 'apache:master' into develop_Nilesh_1.4.0
iGN5117 816e4ed
Fix failing scala test case
iGN5117 472c383
Merge branch 'develop_Nilesh_1.4.0' of https://github.com/iGN5117/sed…
iGN5117 471a87e
Updated documentation to include negative flow.
iGN5117 b33499d
Removed Spark SQL from flink documentation
iGN5117 0d68337
Add ST_Force3D to sedona
iGN5117 d1e4365
Merge branch 'sedona-master' into develop_Nilesh_1.4.0
iGN5117 da0314a
Updated force3D logic to handle empty geometries
iGN5117 020e9b9
Updated force3D dataframe test
iGN5117 86de054
fix error in test case
iGN5117 307c060
Updated documentation for Force3D to include Z format WKT in the outp…
iGN5117 dbab04c
Added default zValue test case in sedona flink
iGN5117 c0eb8bc
Added default zValue dataframe test case
iGN5117 479b264
Added default zValue scala test case
iGN5117 641d2d9
fix dataframe testcase
iGN5117 c2e27d8
Addressed PR comments
iGN5117 4fa254d
Merge branch 'develop_Nilesh_1.4.0' into documentation_update_Nilesh
iGN5117 9815161
Update community/develop to include steps to run python test cases.
iGN5117 5bdf476
Merge branch 'apache:master' into documentation_update_Nilesh
iGN5117 b5cf30c
Add ST_NRings
iGN5117 b89cec1
Add ST_Translate
iGN5117 b49d789
Merge branch 'develop_Nilesh_1.4.1_Translate' of https://github.com/i…
iGN5117 ece4802
Updated GeomUtils to remove redundant geom return type
iGN5117 78be0f1
Simplified ST_Translate implementation, updated test cases and docs
iGN5117 cd12ce2
Updated tests for Translate
iGN5117 19016ae
temp affine commit
iGN5117 959b35c
core logic implementation of BoundingDiagonal (without fits parameter)
iGN5117 00d0e48
Revert "temp affine commit"
iGN5117 0e23430
Implement BoundingDiagonal
iGN5117 e04f668
Merge branch 'sedona-master' into develop_Nilesh_1.4.1_BoundingDiagonal
iGN5117 f18099e
Add flink test case
iGN5117 ea6ea55
Reduce loops in ST_BoundingDiagonal
iGN5117 73e28c0
Add ST_HausdorffDistance
iGN5117 170a5d3
Merge branch 'master' into develop_Nilesh_1.4.1_HausdorffDistance
iGN5117 da353af
Merge branch 'sedona-master' into develop_Nilesh_1.4.1_HausdorffDistance
iGN5117 a1fea92
backmerge with master
iGN5117 be96258
Support optimized join for ST_HausdorffDistance
iGN5117 0a4e1e7
Updated optimizer documentation for hausdorffDistance
iGN5117 859bf8f
Merge branch 'master' into develop_Nilesh_1.4.1_HausdorffDistance
iGN5117 b20716f
fix query mistake
iGN5117 7e777d8
Added distance candidates with results > 100
iGN5117 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what the number of expected intersects is in these test cases? Can you report the numbers here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iGN5117
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, both intersects (<=) and non-intersects (<) return a count of 100 for this dataset. The polygon-point pairs are also exactly same since there is no pair with frechetDistance == 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more distanceCandidates? Most importantly, add some candidates that lead to results > 100.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added candidates 1, 2, 5, 10. These yield result 100, 298, 688, 1258 respectively for a sample size of 100