-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-636] Support GEOMETRY in Spark SQL table creation DDL #1543
[SEDONA-636] Support GEOMETRY in Spark SQL table creation DDL #1543
Conversation
There are breaking changes to the SparkSqlParser and SparkSqlAstBuilder, that removed the configuration from the constructor (committed on Nov 14, 2020 ). The spark 3.0.3 thus failed. |
What happens to the I understand that it could create some redundant code but I believe we should still replicate the tests to all profiles. What do you think? @zhangfengcdt |
@jiayuasu I've just added the unit tests to all spark versions we currently support. For spark-3.0, I also refactor the custom sedona sql parser constructor to take the extra |
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-636] my subject
.What changes were proposed in this PR?
This PR add the geometry type in the table creation DDL. For example:
Before the change, it throws error below:
DataType geometryee is not supported.(line 1, pos 62)
== SQL ==
CREATE TABLE T_TEST_EXPLICIT_GEOMETRY_2 (INT_COL INT, GEO_COL GEOMETRY)
--------------------------------------------------------------^^^
How was this patch tested?
new unit test: SQLSyntaxTestScala
Did this PR include necessary documentation updates?