[Feature][Connector-V2] Add Handling Logic for HBase Asynchronous Data Write Failures #8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Dec 12, 2024
| .writeBufferSize(hbaseParameters.getWriteBufferSize()) | ||
| .listener( | ||
| (e, mutator) -> { | ||
| for (int i = 0; i < e.getNumExceptions(); i++) { |
There was a problem hiding this comment.
what's happend when all retry failed?
There was a problem hiding this comment.
what's happend when all retry failed?
It is indeed a bug, and I haven't thought of a good way to prevent this situation from occurring. Moreover, there is currently no relevant log information when HBase write failures happen.
There was a problem hiding this comment.
we should handle this situation before merge this PR.
There was a problem hiding this comment.
the HBase client itself will also perform a certain number of retries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add Handling Logic for HBase Asynchronous Data Write Failures, Including Retries for Data Write Failures Caused by Temporary Region Unavailability Due to Region Split or Region Balance
Does this PR introduce any user-facing change?
no
How was this patch tested?
exist tests
Check list
New License Guide
release-note.