[Bug][Connector-v2] MongoDB CDC Set SeatunnelRow's tableId #7935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Oct 31, 2024
...seatunnel/connectors/seatunnel/cdc/mongodb/sender/MongoDBConnectorDeserializationSchema.java
Show resolved
Hide resolved
hailin0
previously approved these changes
Nov 1, 2024
Hisoka-X
reviewed
Nov 1, 2024
...a/org/apache/seatunnel/connectors/seatunnel/cdc/mongodb/MongodbIncrementalSourceFactory.java
Show resolved
Hide resolved
Hisoka-X
added
the
don't merge
Hisoka-X
reviewed
Nov 5, 2024
| @@ -310,3 +241,6 @@ sink { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Feature | |||
| - Support Multi-table Synchronization for MongoDB-CDC. | |||
| "inventory.products", | ||
| keyDocument, | ||
| valueDocument); | ||
| Object tableId = ReflectionUtils.invoke(schema, "extractTableId", sourceRecord); |
There was a problem hiding this comment.
we can use @VisibleForTesting annotation to avoid use ReflectionUtils.
Comment on lines
+94
to
+95
| List<String> collections = context.getOptions().get(MongodbSourceOptions.COLLECTION); | ||
| if (collections.size() != configCatalog.size()) { |
There was a problem hiding this comment.
how about add a test case for mongocdc with multi tables.
hailin0
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
method of
MongoDBConnectorDeserializationSchema.extractTableIdnot implemented , The tableId of SeatunnelRow is null, which may affect other downstream operations.How was this patch tested?
Check list
New License Guide
release-note.