[Feature][Connector-Paimon] Support dynamic bucket splitting improves Paimon writing efficiency #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
changed the title
Hisoka-X
reviewed
Aug 7, 2024
dailai
reviewed
Aug 8, 2024
...ink-13/src/main/java/org/apache/seatunnel/translation/flink/sink/FlinkSinkWriterContext.java
Show resolved
Hide resolved
...common/src/main/java/org/apache/seatunnel/translation/flink/sink/FlinkSinkWriterContext.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
2 times, most recently
from
1b445f0
to
a5d18ee
Compare
github-actions
bot
added
the
dependencies
|
Please retrigger the ci. |
dailai
reviewed
Aug 21, 2024
.../java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/bucket/PaimonBucketAssigner.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
5 times, most recently
from
50764df
to
c93f7b8
Compare
github-actions
bot
removed
the
dependencies
|
Thinks @hawk9821 . Good job. I think your e2e case needs to be added to the case of multi-parallelism, the current case is all single parallelism. In this way, we can effectively verify whether the dynamic bucketing will change depending on the degree of parallelism of the job. Also, I think you should check the bucket count in every case instead of making a separate case. In addition, each of your cases should verify that the dynamic-bucket.target-row-num argument works as expected. |
github-actions
bot
added
dependencies
Hisoka-X
reviewed
Sep 2, 2024
Hisoka-X
reviewed
Sep 2, 2024
...n-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonSinkDynamicBucketIT.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
2 times, most recently
from
974e481
to
af318d5
Compare
Hisoka-X
reviewed
Sep 4, 2024
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SinkWriter.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
from
af318d5
to
3874aae
Compare
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
3 times, most recently
from
ad8281b
to
e0cd7d8
Compare
Hisoka-X
reviewed
Sep 13, 2024
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
4 times, most recently
from
dc92c7b
to
a1b351d
Compare
* [Improve] Update snapshot version to 2.3.8 * [Improve] Update snapshot version to 2.3.8
…mon writing efficiency
[Feature][CONNECTORS-V2-Paimon] spark task parallelism
[Feature][CONNECTORS-V2-Paimon] update doc [Feature][CONNECTORS-V2-Paimon] write to dynamic bucket table , spark flink e2e
…mon writing efficiency
hawk9821
force-pushed
the
paimon_dynamic_bucket
branch
from
b34a78a
to
9a7dab1
Compare
hailin0
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support dynamic bucket splitting improves Paimon writing efficiency
Does this PR introduce any user-facing change?
no
How was this patch tested?
e2e: PaimonSinkDynamicBucketIT
UT: PaimonBucketAssignerTest#bucketAssigner
e2e case: PaimonSinkDynamicBucketIT#testPaimonBucketCountOnSparkAndFlink ，because spark and Flink engine can not auto create paimon table on worker node in local file, this e2e case work on local hdfs environment.
Check list
New License Guide
release-note.