[Core][jdk17] Support jdk17 #7086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
document
dependencies
added 2 commits
July 15, 2024 16:18
liugddx
commented
Jul 15, 2024
Comment on lines
+54
to
+60
| public static DateTimeFormatter TIME_FORMAT = | ||
| new DateTimeFormatterBuilder() | ||
| .appendPattern("HH:mm:ss") | ||
| .appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, true) | ||
| .toFormatter(); | ||
|
|
||
| public Map<String, DateTimeFormatter> fieldFormatterMap = new HashMap<>(); |
There was a problem hiding this comment.
Format date format instead using toString. Strings generated in different jdk versions are inconsistent
liugddx
commented
Jul 16, 2024
Comment on lines
270
to
284
| LzopCodec lzo = new LzopCodec(); | ||
| Path path = Paths.get(file.getAbsolutePath() + ".lzo"); | ||
| OutputStream outputStream = lzo.createOutputStream(Files.newOutputStream(path)); | ||
| outputStream.write(Files.readAllBytes(file.toPath())); | ||
| outputStream.close(); | ||
| // Define the output path | ||
| Path path = Paths.get(file.getAbsolutePath() + ".lzma"); | ||
|
|
||
| // Use try-with-resources to ensure streams are closed properly | ||
| try (FileInputStream fis = new FileInputStream(file); | ||
| FileOutputStream fos = new FileOutputStream(path.toFile()); | ||
| LZMACompressorOutputStream lzmaOut = new LZMACompressorOutputStream(fos)) { | ||
|
|
||
| byte[] buffer = new byte[1024]; | ||
| int len; | ||
| while ((len = fis.read(buffer)) != -1) { | ||
| lzmaOut.write(buffer, 0, len); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Resolve Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.RuntimeException: java.lang.reflect.InaccessibleObjectException: Unable to make field long java.nio.Buffer.address accessible: module java.base does not "opens java.nio" to unnamed module @3025782f [in thread "main"]. Skip jdk17 test environment
liugddx
commented
Jul 17, 2024
Comment on lines
+130
to
+131
| final String datetime = "2023-12-22 00:00:00"; | ||
| LocalDateTime parse = DateTimeUtils.parse(datetime, Formatter.YYYY_MM_DD_HH_MM_SS); |
There was a problem hiding this comment.
jdk17 optimizes timestamps and temporarily uses a fixed format
This was referenced Jul 21, 2024
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Refer to https://issues.apache.org/jira/browse/FLINK-15736
LocalFileITtest on jdk 17Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.