Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Doc] Add RocketMq connector #5361

Merged
merged 10 commits into from
Oct 10, 2023
Merged

[Feature][Doc] Add RocketMq connector #5361

merged 10 commits into from
Oct 10, 2023

Conversation

zhilinli123
Copy link
Contributor

subTask:#4572

@Hisoka-X Hisoka-X changed the title [Feature][doc][Connector-V2][RocketMq] Add RocketMq connector [Feature][Doc] Add RocketMq connector Aug 24, 2023
Hisoka-X
Hisoka-X reviewed Aug 24, 2023
View reviewed changes
docs/en/connector-v2/sink/RocketMQ.md
@@ -1,8 +1,12 @@
# RocketMQ

> RocketMQ sink connector
>
## Description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add supported engine follow https://github.com/apache/seatunnel/pull/5132/files#diff-1adcb2672f956c38a665af1cb0b5dab052f2e1e8b822dc33032320ce1a3bceb2R5-R9

docs/en/connector-v2/source/RocketMQ.md
@@ -2,6 +2,10 @@

> RocketMQ source connector

## Support Apache RocketMQ Version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

docs/en/connector-v2/source/RocketMQ.md Outdated
## Example

### Simple
> random generation data is sent to Rocketmq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The describe not right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,thanks review

@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Aug 24, 2023
@zhilinli123 zhilinli123 mentioned this pull request Aug 29, 2023
Closed
3 tasks
EricJoy2048
EricJoy2048 previously requested changes Sep 1, 2023
View reviewed changes
docs/en/connector-v2/sink/RocketMQ.md Outdated
| access.key | String | no | | When ACL_ENABLED is true, access key cannot be empty |
| secret.key | String | no | | When ACL_ENABLED is true, secret key cannot be empty |
| producer.group | String | no | SeaTunnel-producer-Group | SeaTunnel-producer-Group |
| semantic | string | no | NON | Semantics that can be chosen EXACTLY_ONCE/AT_LEAST_ONCE/NON, default NON. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you read the RocketMqSinkFactory code? Some options I don't found in the code.

image

Copy link
Contributor Author

@zhilinli123 zhilinli123 Sep 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this parameter semantic?
I found the rest in here
org.apache.seatunnel.connectors.seatunnel.rocketmq.config.ProducerConfig
org.apache.seatunnel.connectors.seatunnel.rocketmq.config.Config

@EricJoy2048
Copy link
Member

It seems that many of the key options do not add examples to tell users how to use them. Can I add more examples?

@zhilinli123
Copy link
Contributor Author

PTAL: @EricJoy2048 @Hisoka-X I made some changes

liugddx
liugddx approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx liugddx merged commit e8793bb into apache:dev Oct 10, 2023
33 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
@zhilinli123
[Feature][Doc] Add RocketMq connector (apache#5361)
c8f7b07 
* [Feature][doc][Connector-V2][RocketMq] Add RocketMq connector

* [Feature][doc][Connector-V2][RocketMq] Add RocketMq connector

* [Feature][doc][Connector-V2][RocketMq] Add RocketMq connector

* fix

* add case
@zhilinli123 zhilinli123 mentioned this pull request Oct 17, 2023
Closed
3 tasks
@zhilinli123 zhilinli123 mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X left review comments

@liugddx liugddx liugddx approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 document feature New feature reviewed Waiting for code update
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@zhilinli123 @EricJoy2048 @Hisoka-X @liugddx