-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update][install-plugin.sh] Change script version to 2.3.3 #5348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution!
IMO, If the user does not specify a version when downloading the plugin, 2.3.1 will be downloaded by default, which may not be what the user wants to see. |
In fact, we would change the version value when we prepare release. 576f76f |
Um. This is also possible, but we need to modify it every time we publish. |
Yes, not a big deal than user configure it. |
Can this pr change the version to 2.3.3 or turn it off? |
Let's change it to 2.3.3 @tungbq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tungbq
Purpose of this pull request
Show specified version instead of default
Closes: #5347
Check list
New License Guide
release-note
.