Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update][install-plugin.sh] Change script version to 2.3.3 #5348

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented Aug 21, 2023

Purpose of this pull request

Show specified version instead of default
Closes: #5347

Check list

@liugddx liugddx added the First-time contributor First-time contributor label Aug 21, 2023
liugddx
liugddx previously approved these changes Aug 21, 2023
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution!

@Hisoka-X
Copy link
Member

@liugddx Hi, why we should do this change? This change makes our work easier by making it more complicated for users, which I don't think is a good approach. cc@EricJoy2048 @hailin0

@liugddx
Copy link
Member

liugddx commented Aug 21, 2023

@liugddx Hi, why we should do this change? This change makes our work easier by making it more complicated for users, which I don't think is a good approach. cc@EricJoy2048 @hailin0

IMO, If the user does not specify a version when downloading the plugin, 2.3.1 will be downloaded by default, which may not be what the user wants to see.

@Hisoka-X
Copy link
Member

In fact, we would change the version value when we prepare release. 576f76f

@liugddx
Copy link
Member

liugddx commented Aug 21, 2023

In fact, we would change the version value when we prepare release. 576f76f

Um. This is also possible, but we need to modify it every time we publish.

@Hisoka-X
Copy link
Member

Yes, not a big deal than user configure it.

@liugddx
Copy link
Member

liugddx commented Aug 21, 2023

In fact, we would change the version value when we prepare release. 576f76f

Um. This is also possible, but we need to modify it every time we publish.

Yes, not a big deal than user configure it.

Can this pr change the version to 2.3.3 or turn it off?

@Hisoka-X
Copy link
Member

Let's change it to 2.3.3 @tungbq

@tungbq
Copy link
Contributor Author

tungbq commented Aug 21, 2023

Let's change it to 2.3.3 @tungbq

So we keep the script approach as is, revert current change in this PR, only change the version to 2.3.3. Is that right? @Hisoka-X @liugddx

@Hisoka-X
Copy link
Member

Let's change it to 2.3.3 @tungbq

So we keep the script approach as is, revert current change in this PR, only change the version to 2.3.3. Is that right? @Hisoka-X @liugddx

Yes, please.

@liugddx
Copy link
Member

liugddx commented Aug 21, 2023

Let's change it to 2.3.3 @tungbq

So we keep the script approach as is, revert current change in this PR, only change the version to 2.3.3. Is that right? @Hisoka-X @liugddx

Yes

@tungbq
Copy link
Contributor Author

tungbq commented Aug 21, 2023

Sure, updated version to 2.3.3! @Hisoka-X @liugddx

@tungbq tungbq changed the title [Improve][install-plugin.sh] Show specified version instead of default [Update][install-plugin.sh] Change script version to 2.3.3 Aug 21, 2023
@tungbq tungbq requested a review from liugddx August 21, 2023 12:02
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tungbq

@Hisoka-X Hisoka-X merged commit 9e85d12 into apache:dev Aug 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][install-plugin.sh] Show specified version instead of default
3 participants