-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser #5071 #5332
Merged
EricJoy2048
merged 3 commits into
apache:dev
from
aijing-sun:dev_starrocks_autocreate_parser
Sep 11, 2023
Merged
[Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser #5071 #5332
EricJoy2048
merged 3 commits into
apache:dev
from
aijing-sun:dev_starrocks_autocreate_parser
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffset && add primary key for default template
aijing-sun
changed the title
[Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser
[Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser #5071
Aug 18, 2023
Hisoka-X
reviewed
Aug 23, 2023
.../test/java/org/apache/seatunnel/connectors/seatunnel/starrocks/StarRocksCreateTableTest.java
Show resolved
Hide resolved
…emplate in testcase. Signed-off-by: aijing <[email protected]>
aijing-sun
force-pushed
the
dev_starrocks_autocreate_parser
branch
from
August 23, 2023 17:34
2229c18
to
77b3e17
Compare
It's done. PTAL @Hisoka-X |
Hisoka-X
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @aijing-sun Thanks
EricJoy2048
approved these changes
Sep 11, 2023
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…pache#5071 (apache#5332) * [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…pache#5071 (apache#5332) * [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
…pache#5071 (apache#5332) * [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
gnehil
pushed a commit
to gnehil/seatunnel
that referenced
this pull request
Oct 12, 2023
…pache#5071 (apache#5332) * [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix starrocks template sql parser offset && add primary key for default template
This resolves #5071
Purpose of this pull request
Check list
New License Guide
release-note
.