Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser #5071 #5332

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

aijing-sun
Copy link
Contributor

@aijing-sun aijing-sun commented Aug 18, 2023

fix starrocks template sql parser offset && add primary key for default template

This resolves #5071

Purpose of this pull request

Check list

…ffset && add primary key for default template
@aijing-sun aijing-sun changed the title [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser #5071 Aug 18, 2023
@Hisoka-X Hisoka-X added this to the 2.3.4 milestone Aug 21, 2023
@aijing-sun aijing-sun force-pushed the dev_starrocks_autocreate_parser branch from 2229c18 to 77b3e17 Compare August 23, 2023 17:34
@aijing-sun
Copy link
Contributor Author

It's done. PTAL @Hisoka-X

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @aijing-sun Thanks

@EricJoy2048 EricJoy2048 merged commit 23d79b0 into apache:dev Sep 11, 2023
42 checks passed
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
…pache#5071 (apache#5332)

* [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
…pache#5071 (apache#5332)

* [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
…pache#5071 (apache#5332)

* [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
…pache#5071 (apache#5332)

* [Hotfix][Connector-V2][StarRocks] fix starrocks template sql parser offset && add primary key for default template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Connector-V2] StarRocks Auto Create Table parse failed.
3 participants