Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][SqlServer] Support driver jtds for SqlServer #5307 #5311

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

Mrkuhuo
Copy link

@Mrkuhuo Mrkuhuo commented Aug 15, 2023

#5307

Purpose of this pull request

Check list

@liugddx liugddx added the First-time contributor First-time contributor label Aug 21, 2023
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case?

@byteteacher0
Copy link

Can you add a test case?

env {
execution.parallelism = 1
job.mode = "BATCH"
}

source {
Jdbc {
driver = net.sourceforge.jtds.jdbc.Driver
url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master"
user = sa
password = "Admin@123"
query = "select * from MSreplication_options"
}

}

sink {
Jdbc {
driver = net.sourceforge.jtds.jdbc.Driver
url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master"
user = sa
password = "Admin@123"
query = "insert into MSreplication_options1(optname, value, major_version, minor_version, revision, install_failures) values(?,?,?,?,?,?)"
}

}

@liugddx
Copy link
Member

liugddx commented Aug 24, 2023

Can you add a test case?

env { execution.parallelism = 1 job.mode = "BATCH" }

source { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "select * from MSreplication_options" }

}

sink { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "insert into MSreplication_options1(optname, value, major_version, minor_version, revision, install_failures) values(?,?,?,?,?,?)" }

}

can you add an e2e test?

@Mrkuhuo
Copy link
Author

Mrkuhuo commented Aug 24, 2023

Can you add a test case?

env { execution.parallelism = 1 job.mode = "BATCH" }
source { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "select * from MSreplication_options" }
}
sink { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "insert into MSreplication_options1(optname, value, major_version, minor_version, revision, install_failures) values(?,?,?,?,?,?)" }
}

can you add an e2e test?

ok

@Mrkuhuo
Copy link
Author

Mrkuhuo commented Aug 24, 2023

@Mrkuhuo Mrkuhuo closed this Aug 24, 2023
@Mrkuhuo Mrkuhuo reopened this Aug 24, 2023
@Mrkuhuo
Copy link
Author

Mrkuhuo commented Aug 24, 2023

Can you add a test case?

env { execution.parallelism = 1 job.mode = "BATCH" }
source { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "select * from MSreplication_options" }
}
sink { Jdbc { driver = net.sourceforge.jtds.jdbc.Driver url = "jdbc:jtds:sqlserver://192.168.154.128:1433/master" user = sa password = "Admin@123" query = "insert into MSreplication_options1(optname, value, major_version, minor_version, revision, install_failures) values(?,?,?,?,?,?)" }
}

can you add an e2e test?

The code has been submitted

@Hisoka-X Hisoka-X linked an issue Aug 24, 2023 that may be closed by this pull request
3 tasks
@Hisoka-X
Copy link
Member

Hi, please use mvn spotless:apply to format the code. The code style check failed.

@Mrkuhuo
Copy link
Author

Mrkuhuo commented Aug 24, 2023

Hi, please use mvn spotless:apply to format the code. The code style check failed.

it's ok

@Mrkuhuo
Copy link
Author

Mrkuhuo commented Sep 18, 2023

Hi, please use mvn spotless:apply to format the code. The code style check failed.

Please see if there are any other problems

@liugddx
Copy link
Member

liugddx commented Sep 18, 2023

Hi, please use mvn spotless:apply to format the code. The code style check failed.

Please see if there are any other problems
CI reported an error
https://github.com/apache/seatunnel/actions/runs/5965148506/job/16183803372?pr=5311#step:4:13903

@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

image

@EricJoy2048
Copy link
Member

Hi, @WuZongYun Is there any new progress in this pr?

@EricJoy2048
Copy link
Member

@chl-wxp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connector-V2][SqlServer] Support driver jtds for SqlServer
6 participants