Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][SeaTunnel Engine IMap Storage] Imap storage supports kafka compact topic in cluster mode #5024

Closed
wants to merge 2 commits into from
Closed

[Feature][SeaTunnel Engine IMap Storage] Imap storage supports kafka compact topic in cluster mode #5024

wants to merge 2 commits into from

Conversation

sunxiaojian
Copy link
Contributor

Purpose of this pull request

Check list

@sunxiaojian sunxiaojian force-pushed the support-kafka-compact-topic branch 4 times, most recently from 58631df to 404336e Compare July 5, 2023 03:05
@sunxiaojian
Copy link
Contributor Author

@EricJoy2048 PTAL

@sunxiaojian sunxiaojian force-pushed the support-kafka-compact-topic branch 6 times, most recently from 9c88f1c to bd395bc Compare July 5, 2023 15:18
@EricJoy2048
Copy link
Member

@liugddx PTAL.

liugddx
liugddx reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the test cases disabled? We need to add some test cases that can be used to ensure that this feature can be used.

@sunxiaojian
Copy link
Contributor Author

Why are the test cases disabled? We need to add some test cases that can be used to ensure that this feature can be used.

The test is connected to my local environment

@liugddx
Copy link
Member

liugddx commented Jul 6, 2023

Why are the test cases disabled? We need to add some test cases that can be used to ensure that this feature can be used.

The test is connected to my local environment

Is there a way to enable testing?

@sunxiaojian
Copy link
Contributor Author

Is there a way to enable testing?

Can be processed using kafka container

@EricJoy2048
Copy link
Member

Yes, I think you can enable the test case by use kafka container.

@sunxiaojian sunxiaojian force-pushed the support-kafka-compact-topic branch 2 times, most recently from a912a1a to b08dba6 Compare July 12, 2023 02:25
@sunxiaojian
Copy link
Contributor Author

Yes, I think you can enable the test case by use kafka container.

done

liugddx
liugddx reviewed Jul 12, 2023
View reviewed changes
seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/pom.xml
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this dependency?

pom.xml Outdated
@@ -146,6 +146,7 @@
<json-smart.version>2.4.7</json-smart.version>
<hadoop-aws.version>3.1.4</hadoop-aws.version>
<netty-buffer.version>4.1.60.Final</netty-buffer.version>
<kafka.version>3.4.1</kafka.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support those versions of kafka?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support those versions of kafka?

Backward compatibility.

seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-kafka/pom.xml
Comment on lines +63 to +68
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

for testcontainer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/seatunnel/blob/6060b13f9f9a223fd0a85c33d98e5f86df3aa254/pom.xml#L530C9-L530C9

@liugddx
Copy link
Member

liugddx commented Jul 12, 2023

I have a question, why use kafka as storage?

@sunxiaojian
Copy link
Contributor Author

I have a question, why use kafka as storage?

Kafka compact topic:

  1. Support message merging with the same key, automatically achieve file compression, effectively improve restart loading speed
  2. Supports tombstone messages. During the data compression and merging process, tombstone messages can be cleared to reduce storage space
  3. Support for unstructured storage, Conforming to Zeta engine storage scenarios （Can refer to the design of Kafka connect）
  4. Open source, widely used

liugddx
liugddx reviewed Jul 12, 2023
View reviewed changes
seatunnel-engine/seatunnel-engine-storage/imap-storage-plugins/imap-storage-kafka/pom.xml
Comment on lines +63 to +68
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricJoy2048 @Hisoka-X PTAL

liugddx
liugddx previously approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

@ic4y
Copy link
Contributor

ic4y commented Aug 5, 2023

The latest dev branch has addressed e2e test issues. Please consider merging it.

@sunxiaojian sunxiaojian force-pushed the support-kafka-compact-topic branch 2 times, most recently from 18e46b8 to 17befc4 Compare August 7, 2023 02:33
@sunxiaojian
Copy link
Contributor Author

The latest dev branch has addressed e2e test issues. Please consider merging it.

@ic4y There are still errors

@liugddx
Copy link
Member

liugddx commented Aug 7, 2023

Waiting for #5208

@sunxiaojian sunxiaojian force-pushed the support-kafka-compact-topic branch 4 times, most recently from 259119e to 0586b14 Compare August 8, 2023 12:08
@sunxiaojian
Copy link
Contributor Author

@liugddx @ic4y PTAL

@sunxiaojian sunxiaojian deleted the support-kafka-compact-topic branch September 6, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liugddx liugddx liugddx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunxiaojian @EricJoy2048 @liugddx @ic4y