Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9050] Fix repeat response code #9051

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #9050] Fix repeat response code #9051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1902fd1
fix repeat code
bxfjb Dec 12, 2024
bd20b0f
fix ut
bxfjb Dec 12, 2024
b75f678
modify code
bxfjb Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client/src/test/java/org/apache/rocketmq/client/impl/MQClientAPIImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ public void testCreatePlainAccessConfig_Exception() throws InterruptedException,
try {
mqClientAPI.createPlainAccessConfig(brokerAddr, config, 3 * 1000);
} catch (MQClientException ex) {
assertThat(ex.getResponseCode()).isEqualTo(209);
assertThat(ex.getResponseCode()).isEqualTo(ResponseCode.UPDATE_AND_CREATE_ACL_CONFIG_FAILED);
assertThat(ex.getErrorMessage()).isEqualTo("corresponding to accessConfig has been updated failed");
}
}
Expand Down Expand Up @@ -419,7 +419,7 @@ public void testDeleteAccessConfig_Exception() throws InterruptedException, Remo
try {
mqClientAPI.deleteAccessConfig(brokerAddr, "11111", 3 * 1000);
} catch (MQClientException ex) {
assertThat(ex.getResponseCode()).isEqualTo(210);
assertThat(ex.getResponseCode()).isEqualTo(ResponseCode.DELETE_ACL_CONFIG_FAILED);
assertThat(ex.getErrorMessage()).isEqualTo("corresponding to accessConfig has been deleted failed");
}
}
Expand Down
13 changes: 7 additions & 6 deletions remoting/src/main/java/org/apache/rocketmq/remoting/protocol/ResponseCode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,6 @@ public class ResponseCode extends RemotingSysResponseCode {

public static final int NO_MESSAGE = 208;

public static final int UPDATE_AND_CREATE_ACL_CONFIG_FAILED = 209;

public static final int DELETE_ACL_CONFIG_FAILED = 210;

public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 211;

public static final int POLLING_FULL = 209;

public static final int POLLING_TIMEOUT = 210;
Expand All @@ -90,6 +84,12 @@ public class ResponseCode extends RemotingSysResponseCode {

public static final int FLOW_CONTROL = 215;

public static final int UPDATE_AND_CREATE_ACL_CONFIG_FAILED = 216;

public static final int DELETE_ACL_CONFIG_FAILED = 217;

public static final int UPDATE_GLOBAL_WHITE_ADDRS_CONFIG_FAILED = 218;

public static final int NOT_LEADER_FOR_QUEUE = 501;

public static final int ILLEGAL_OPERATION = 604;
Expand Down Expand Up @@ -134,4 +134,5 @@ public class ResponseCode extends RemotingSysResponseCode {
public static final int USER_NOT_EXIST = 3001;

public static final int POLICY_NOT_EXIST = 3002;

}
Loading