Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #660] Add namespace in java client #661

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Dec 29, 2023

Which Issue(s) This PR Fixes

Fixes #660

Brief Description

Add namespace in java client

How Did You Test This Change?

@drpmma drpmma added the Java label Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (2d3cdf7) 46.69% compared to head (f466ae1) 47.06%.

Files Patch % Lines
...mq/client/java/impl/consumer/PushConsumerImpl.java 27.27% 8 Missing ⚠️
...cketmq/client/java/impl/producer/ProducerImpl.java 25.00% 6 Missing ⚠️
.../client/java/impl/producer/PublishingSettings.java 62.50% 3 Missing ⚠️
...tmq/client/java/message/PublishingMessageImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #661      +/-   ##
============================================
+ Coverage     46.69%   47.06%   +0.36%     
- Complexity      651      668      +17     
============================================
  Files           207      207              
  Lines         12120    12146      +26     
  Branches       3510     3504       -6     
============================================
+ Hits           5659     5716      +57     
+ Misses         6212     6179      -33     
- Partials        249      251       +2     
Flag Coverage Δ
java 62.94% <68.96%> (+1.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma merged commit 0aaf9f9 into apache:master Jan 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add namespace in java client
3 participants