Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][client] Add logging when lib disabled sni even after passing proxy-url #23545

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Nov 2, 2024

Motivation

Currently if user passes proxy-url and proxy-protocol and if user doesn't pass tls param or makes a typo in service-url-tls (eg:: ppulsar+ssl) then client lib thinks tls is disabled and doesn't enable SNI proxy without any log message which creates connection failures and makes very difficult for users to debug. so, log the message when client lib disables SNI proxy even after passing complete SNI information.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/client doc-not-needed Your PR changes do not impact docs ready-to-test labels Nov 2, 2024
@rdhabalia rdhabalia self-assigned this Nov 2, 2024
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Nov 2, 2024
Copy link

github-actions bot commented Nov 2, 2024

@rdhabalia Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (bbc6224) to head (fe64e62).
Report is 717 commits behind head on master.

Files with missing lines Patch % Lines
.../org/apache/pulsar/client/impl/ConnectionPool.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23545      +/-   ##
============================================
+ Coverage     73.57%   74.29%   +0.71%     
- Complexity    32624    34931    +2307     
============================================
  Files          1877     1943      +66     
  Lines        139502   147062    +7560     
  Branches      15299    16213     +914     
============================================
+ Hits         102638   109253    +6615     
- Misses        28908    29375     +467     
- Partials       7956     8434     +478     
Flag Coverage Δ
inttests 27.32% <0.00%> (+2.73%) ⬆️
systests 24.35% <0.00%> (+0.03%) ⬆️
unittests 73.68% <50.00%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/client/impl/ConnectionPool.java 74.88% <50.00%> (+0.36%) ⬆️

... and 654 files with indirect coverage changes

@lhotari lhotari merged commit c811801 into apache:master Nov 6, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants