Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][io] Support update subscription position for sink connector #23538

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Nov 1, 2024

Motivation

Support update subscription position for sink connector

Modifications

  • Support update subscription position for sink connector

Verifying this change

Add test to cover it.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@shibd shibd added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/connector ready-to-test release/3.3.3 release/3.0.8 release/4.0.1 labels Nov 1, 2024
@shibd shibd self-assigned this Nov 1, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 1, 2024
Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for verify the setSourceSubscriptionPosition method.

@shibd shibd requested a review from nodece November 1, 2024 08:48
@nodece nodece merged commit 3f12269 into apache:master Nov 5, 2024
51 of 52 checks passed
shibd added a commit that referenced this pull request Nov 5, 2024
shibd added a commit that referenced this pull request Nov 5, 2024
shibd added a commit that referenced this pull request Nov 5, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 5, 2024
nodece pushed a commit to ascentstream/pulsar that referenced this pull request Nov 6, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 7, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector cherry-picked/branch-3.0 cherry-picked/branch-3.3 cherry-picked/branch-4.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.8 release/3.3.3 release/4.0.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants