-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][io] Support update subscription position for sink connector #23538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
area/connector
ready-to-test
release/3.3.3
release/3.0.8
release/4.0.1
labels
Nov 1, 2024
nodece
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for verify the setSourceSubscriptionPosition
method.
RobertIndie
approved these changes
Nov 5, 2024
nodece
approved these changes
Nov 5, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 5, 2024
…apache#23538) (cherry picked from commit 3f12269) (cherry picked from commit eca6af3)
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Nov 6, 2024
…apache#23538) (cherry picked from commit 3f12269)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 7, 2024
…apache#23538) (cherry picked from commit 3f12269) (cherry picked from commit eca6af3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 7, 2024
…apache#23538) (cherry picked from commit 3f12269) (cherry picked from commit eca6af3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connector
cherry-picked/branch-3.0
cherry-picked/branch-3.3
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.8
release/3.3.3
release/4.0.1
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support update subscription position for sink connector
Modifications
Verifying this change
Add test to cover it.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: