-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Fix the javadoc for startMessageIdInclusive #23508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Oct 23, 2024
Technoboy-
added
ready-to-test
and removed
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
labels
Oct 30, 2024
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Oct 30, 2024
lhotari
approved these changes
Oct 30, 2024
BewareMyPower
approved these changes
Oct 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23508 +/- ##
============================================
+ Coverage 73.57% 74.35% +0.77%
- Complexity 32624 34428 +1804
============================================
Files 1877 1943 +66
Lines 139502 147045 +7543
Branches 15299 16205 +906
============================================
+ Hits 102638 109330 +6692
- Misses 28908 29282 +374
- Partials 7956 8433 +477
Flags with carried forward coverage won't be shown. Click here to find out more. |
heesung-sn
pushed a commit
to heesung-sn/pulsar
that referenced
this pull request
Nov 5, 2024
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
lhotari
pushed a commit
that referenced
this pull request
Nov 13, 2024
(cherry picked from commit 170be11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-4.0
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
ready-to-test
release/4.0.1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23498
Motivation
The
Consumer#seek(long)
andstartMessageIdInclusive
have no relation. Whether startMessageIdInclusive is present or not, Consumer#seek(long) that seek by timestamp will contain the firstMessageId.In the code, we can see that the
Consumer#seek(long)
seekMessageId use the MessageId.earliest.Modifications
remove the
Consumer#seek(long)
in comment ofReaderBuilder#startMessageIdInclusive
andConsumerBuilder#startMessageIdInclusive
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: