[fix][broker] fix broker may lost rack information

[TakaHiR07]

Main Issue: #23330

Relevant issue: #23282, #23283

Motivation

Fix another issue cause broker lost rack information. There is a previous issue also cause broker lost rack information.

Modifications

This is the first potential fix, when construct bookieClient and do watchWritableBookies() to register listener, trigger each listener in writableBookiesWatchers.

This fix can ensure multiple listeners is trigger in a sync way, but it would bring duplicate trigger problem. Since watchWritableBookies() is only executed twice when bookieClient construct. I think the duplicate trigger problem is acceptable.

Alternative fix is to make BookieRackAffinityMapping#watchAvailableBookies become sync method. Change to registrationClient.watchWritableBookies(......).get() in BookieRackAffinityMapping#watchAvailableBookies. Now it is async.

Verifying this change

• Make sure that the change passes the CI checks.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[lhotari]

LGTM. Thanks for the contribution @TakaHiR07

[lhotari]

closing and reopening to trigger CI

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.06%. Comparing base (bbc6224) to head (46ea59b).
Report is 917 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23331      +/-   ##
============================================
- Coverage     73.57%   71.06%   -2.51%     
- Complexity    32624    34100    +1476     
============================================
  Files          1877     1973      +96     
  Lines        139502   175999   +36497     
  Branches      15299    23334    +8035     
============================================
+ Hits         102638   125080   +22442     
- Misses        28908    41314   +12406     
- Partials       7956     9605    +1649     

Flag	Coverage Δ
inttests	31.78% <100.00%> (+7.20%)	⬆️
systests	27.28% <100.00%> (+2.95%)	⬆️
unittests	70.50% <100.00%> (-2.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../metadata/bookkeeper/PulsarRegistrationClient.java	83.11% <100.00%> (+0.22%)	⬆️

... and 932 files with indirect coverage changes