Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering #23309

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Sep 14, 2024

Motivation

Read the pip-379.md document in this PR.

Mailing list discussion thread

implementation PR: #23352

4.0.x docs: https://pulsar.apache.org/docs/4.0.x/concepts-messaging/#preserving-order-of-message-delivery-by-key

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.0.0 milestone Sep 14, 2024
@lhotari lhotari self-assigned this Sep 14, 2024
@github-actions github-actions bot added the PIP label Sep 14, 2024
@lhotari lhotari changed the title PIP-379: Key_Shared Draining Hashes for Improved Message Ordering [improve][pip] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering Sep 14, 2024
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 14, 2024
Copy link
Contributor

@equanz equanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

I'd like to ask you some questions as I still don't understand some parts.

pip/pip-379.md Outdated Show resolved Hide resolved
pip/pip-379.md Outdated Show resolved Hide resolved
pip/pip-379.md Outdated Show resolved Hide resolved
pip/pip-379.md Outdated Show resolved Hide resolved
pip/pip-379.md Show resolved Hide resolved
pip/pip-379.md Outdated Show resolved Hide resolved
@lhotari lhotari added the release/blocker Indicate the PR or issue that should block the release until it gets resolved label Sep 27, 2024
pip/pip-379.md Outdated Show resolved Hide resolved
pip/pip-379.md Outdated Show resolved Hide resolved
Copy link
Contributor

@equanz equanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I look forward to achieving this goal.

@lhotari lhotari merged commit 64e9687 into apache:master Oct 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP ready-to-test release/blocker Indicate the PR or issue that should block the release until it gets resolved type/PIP
Development

Successfully merging this pull request may close these issues.

3 participants