-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering #23309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
changed the title
PIP-379: Key_Shared Draining Hashes for Improved Message Ordering
[improve][pip] PIP-379: Key_Shared Draining Hashes for Improved Message Ordering
Sep 14, 2024
github-actions
bot
added
the
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
label
Sep 14, 2024
3 tasks
This was referenced Sep 14, 2024
equanz
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
I'd like to ask you some questions as I still don't understand some parts.
lhotari
added
the
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
label
Sep 27, 2024
equanz
reviewed
Oct 3, 2024
equanz
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I look forward to achieving this goal.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
PIP
ready-to-test
release/blocker
Indicate the PR or issue that should block the release until it gets resolved
type/PIP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Read the pip-379.md document in this PR.
Mailing list discussion thread
implementation PR: #23352
4.0.x docs: https://pulsar.apache.org/docs/4.0.x/concepts-messaging/#preserving-order-of-message-delivery-by-key
Documentation
doc
doc-required
doc-not-needed
doc-complete