[fix][broker] fix pulsar-admin topics stats-internal caused a BK client thread a deadlock #23258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
type/bug
poorbarcode
requested review from
lhotari,
Technoboy-,
codelipenghui,
gaoran10 and
shibd
nodece
requested changes
Sep 5, 2024
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
Show resolved
Hide resolved
nodece
changed the title
Technoboy-
reviewed
Sep 5, 2024
pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java
Show resolved
Hide resolved
…ck for the BK client thread
poorbarcode
force-pushed
the
fix/dead_lock_compaction_task
branch
from
8e99caf
to
9096e3a
Compare
Technoboy-
approved these changes
Sep 9, 2024
coderzc
approved these changes
Sep 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23258 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.92%
- Complexity 32624 33755 +1131
============================================
Files 1877 1926 +49
Lines 139502 145064 +5562
Branches 15299 15864 +565
============================================
+ Hits 102638 108078 +5440
+ Misses 28908 28705 -203
- Partials 7956 8281 +325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
approved these changes
Sep 9, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 10, 2024
…nt thread a deadlock (apache#23258) (cherry picked from commit 0aaa906) (cherry picked from commit f5737e6)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 10, 2024
…nt thread a deadlock (apache#23258) (cherry picked from commit 0aaa906) (cherry picked from commit f5737e6)
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
…nt thread a deadlock (apache#23258)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 19, 2024
…nt thread a deadlock (apache#23258) (cherry picked from commit 0aaa906) (cherry picked from commit f5737e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pulsar-admin topics stats-internalcaused a BK client thread deadlock, leading to other ledgers not being opened successfully, and topics not being loaded up.A race condition that will trigger the issue
topics stats-internalModifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x