Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Add arm64 image build #22755

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

nodece
Copy link
Member

@nodece nodece commented May 21, 2024

Motivation

Verify the arm64 image build.

Modifications

  • Use the matrix feature to verify the build of the linux/amd64 and linux/arm64 images.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece self-assigned this May 21, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 21, 2024
@nodece
Copy link
Member Author

nodece commented May 21, 2024

/pulsarbot rerun-failure-checks

@dao-jun dao-jun closed this May 21, 2024
@dao-jun dao-jun reopened this May 21, 2024
@nodece nodece closed this May 22, 2024
@nodece nodece reopened this May 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (bbc6224) to head (7981ee4).
Report is 296 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22755      +/-   ##
============================================
- Coverage     73.57%   73.19%   -0.39%     
- Complexity    32624    32889     +265     
============================================
  Files          1877     1889      +12     
  Lines        139502   141443    +1941     
  Branches      15299    15520     +221     
============================================
+ Hits         102638   103526     +888     
- Misses        28908    29921    +1013     
- Partials       7956     7996      +40     
Flag Coverage Δ
inttests 27.44% <ø> (+2.86%) ⬆️
systests 24.62% <ø> (+0.29%) ⬆️
unittests 72.22% <ø> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 367 files with indirect coverage changes

@nodece nodece marked this pull request as draft May 22, 2024 04:48
.github/workflows/pulsar-ci.yaml Outdated Show resolved Hide resolved
@nodece nodece marked this pull request as ready for review May 23, 2024 10:03
@nodece nodece requested a review from lhotari May 23, 2024 10:04
@nodece nodece closed this May 23, 2024
@nodece nodece reopened this May 23, 2024
@lhotari
Copy link
Member

lhotari commented Jun 6, 2024

btw. arm based runners became public beta a few days ago.
"We expect to begin offering Arm runners for open source projects by the end of the year. "
https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/
https://github.blog/changelog/2024-06-03-actions-arm-based-linux-and-windows-runners-are-now-in-public-beta/

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work @nodece .

@lhotari
Copy link
Member

lhotari commented Jun 6, 2024

Once Arm runners are available (by the end of the year), we could use this type of syntax to choose the runner in the matrix.

  pulsar-java-test-image:
    name: Build Pulsar java-test-image docker image for ${{ matrix.platform }}
    runs-on: ${{ matrix.runs-on }}
    timeout-minutes: 60
    needs: ['preconditions', 'build-and-license-check']
    if: ${{ needs.preconditions.outputs.docs_only != 'true'}}
    strategy:
      fail-fast: false
      matrix:
        include:
          - platform: linux/amd64
            runs-on: ubuntu-22.04
          - platform: linux/arm64
            runs-on: arm64-ubuntu-22.04

@lhotari lhotari merged commit fb03d15 into apache:master Jun 6, 2024
51 of 52 checks passed
@nodece nodece deleted the add-arm64-image-build branch June 6, 2024 08:11
lhotari pushed a commit that referenced this pull request Jun 7, 2024
Signed-off-by: Zixuan Liu <[email protected]>
(cherry picked from commit fb03d15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants