Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][ci] Schedule daily Pulsar CI build with Java 21 #21410

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 21, 2023

Motivation

Run a scheduled daily Java 21 CI build to ensure that Java 21 support doesn't break in master branch.
apache/pulsar master branch currently supports compiling and running all tests with Java 21. A scheduled build with Java 21 will help prevent possible regressions.

Modifications

  • add new scheduled build to pulsar-ci.yaml and pulsar-ci-flaky.yaml which will use Java 21
  • cancel scheduled builds in forks by default so that forks don't waste resources on scheduled Pulsar CI builds

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 3.2.0 milestone Oct 21, 2023
@lhotari lhotari self-assigned this Oct 21, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 21, 2023
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #21410 (1a99e32) into master (772f16c) will increase coverage by 36.53%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #21410       +/-   ##
=============================================
+ Coverage     36.80%   73.33%   +36.53%     
- Complexity      373    32597    +32224     
=============================================
  Files          1711     1888      +177     
  Lines        130699   140298     +9599     
  Branches      14245    15420     +1175     
=============================================
+ Hits          48104   102888    +54784     
+ Misses        76249    29331    -46918     
- Partials       6346     8079     +1733     
Flag Coverage Δ
inttests 24.17% <ø> (-0.01%) ⬇️
systests 24.88% <ø> (-0.03%) ⬇️
unittests 72.62% <ø> (+40.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1456 files with indirect coverage changes

@lhotari lhotari merged commit 0e9bb8a into apache:master Oct 21, 2023
55 checks passed
@cbornet
Copy link
Contributor

cbornet commented Oct 21, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants