-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] fix UniformLoadShedder selecet wrong overloadbroker and underloadbroker #21025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is great - does it need to be backported to prior versions? |
@frankjkelly I'll backport this change to versions after 2.10, including 2.10, 2.11, 3.0 and 3.1 |
That would be wonderful - I am using ThresholdShedder in 2.10.3 and am not thrilled with how complex it is to manage. I'd love to use UniformShedder in 2.11.X with this fix. Thanks so much! |
Fixes #21016
Motivation
fix UniformLoadShedder select the wrong overloadbroker and underloadbroker
Modifications
Documentation
doc-not-needed
Matching PR in forked repository
PR in forked repository: aloyszhang#19