-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] Fix flaky test RawReaderTest #21008
Changes from 11 commits
9d65a87
13fafe1
84beb1f
6b2d1b9
75ece25
d31bed6
33681e6
b64ee22
71403af
06f9c56
28ad518
2618d2c
207fba5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -321,7 +321,7 @@ public void testNegativeAcksDeleteFromUnackedTracker() throws Exception { | |
negativeAcksTracker.close(); | ||
} | ||
|
||
@Test(timeOut = 10000) | ||
@Test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Locally run takes about 8s sometimes, so remove this. |
||
public void testNegativeAcksWithBatchAckEnabled() throws Exception { | ||
cleanup(); | ||
conf.setAcknowledgmentAtBatchIndexLevelEnabled(true); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -529,7 +529,7 @@ protected void txnAckTest(boolean batchEnable, int maxBatchSize, | |
// after transaction abort, the messages could be received | ||
Transaction commitTxn = getTxn(); | ||
for (int i = 0; i < messageCnt; i++) { | ||
message = consumer.receive(2, TimeUnit.SECONDS); | ||
message = consumer.receive(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the network is not good, here will fail. so no need to add timeout for this. |
||
Assert.assertNotNull(message); | ||
consumer.acknowledgeAsync(message.getMessageId(), commitTxn).get(); | ||
log.info("receive msgId: {}, count: {}", message.getMessageId(), i); | ||
|
@@ -741,6 +741,7 @@ private void txnCumulativeAckTest(boolean batchEnable, int maxBatchSize, Subscri | |
for (int i = 0; i < messageCnt; i++){ | ||
producer.newMessage().value("hello".getBytes()).sendAsync(); | ||
} | ||
producer.flush(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Message<byte[]> message = null; | ||
Thread.sleep(1000L); | ||
for (int i = 0; i < messageCnt; i++) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/apache/pulsar/actions/runs/5908119588/job/16027337981?pr=21008