[fix][broker][branch-2.10] Fix NPE when reset Replicator's cursor by position. (#20597) #20781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Jul 12, 2023
codelipenghui
approved these changes
Jul 12, 2023
BewareMyPower
added a commit
that referenced
this pull request
Jul 12, 2023
…eExpiryMonitor ### Motivation #20781 adds a new constructor to `PersistentMessageExpiryMonitor` and initialize the old constructor with ```java this.topic = subscription.topic; ``` NPE will happen when `subscription` is null. However, it's allowed to pass a null `subscription` for test because methods like `findEntryFailed` don't depend on the `topic` field. ### Modifications Add the null check and mark the old constructor as deprecated.
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
…position. (apache#20597) (apache#20781) (cherry picked from commit 643ffad)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 17, 2023
…eExpiryMonitor ### Motivation apache#20781 adds a new constructor to `PersistentMessageExpiryMonitor` and initialize the old constructor with ```java this.topic = subscription.topic; ``` NPE will happen when `subscription` is null. However, it's allowed to pass a null `subscription` for test because methods like `findEntryFailed` don't depend on the `topic` field. ### Modifications Add the null check and mark the old constructor as deprecated. (cherry picked from commit 5c55633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry-pick #20597 and guarantee compatibility.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: