[improve][broker][branch-2.10] Backport Linux metrics changes from master branch #20659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
merlimat,
tisonkun,
eolivelli,
codelipenghui,
michaeljmarshall and
mattisonchao
eolivelli
approved these changes
Jun 27, 2023
michaeljmarshall
approved these changes
Jun 27, 2023
nodece
approved these changes
Jun 28, 2023
| && config.isLoadBalancerEnabled() | ||
| && LinuxInfoUtils.isLinux() | ||
| && !LinuxInfoUtils.checkHasNicSpeeds()) { | ||
| throw new IllegalStateException("Unable to read VM NIC speed. You must set " |
There was a problem hiding this comment.
Notice: If we cannot read the NIC speed, the broker cannot be starting.
There was a problem hiding this comment.
Yes, this code is just copied over from master branch
coderzc
approved these changes
Jun 28, 2023
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Dec 2, 2023
… from master branch (apache#20659)" This reverts commit b355d31.
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 28, 2023
… changes from master branch (apache#20659)"" This reverts commit a47c6ac.
mattisonchao
added a commit
to streamnative/pulsar-archived
that referenced
this pull request
Dec 28, 2023
… changes from master branch (apache#20659)"" This reverts commit a47c6ac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
branch-2.10 doesn't support cgroup v2 currently. AKS Kubernetes 1.25+ switches to use cgroup v2:
https://github.com/Azure/AKS/releases/tag/2023-03-05
GKE contains to have a way to select between cgroup v1 & cgroup v2:
https://cloud.google.com/kubernetes-engine/docs/how-to/node-system-config#cgroup-mode-options
GKE will default to cgroup v2 in new Kubernetes 1.26 clusters or node pools.
AWS EKS v1.26 nodes will default to cgroup v2.
Modifications
Backport #16832 which fixes #16601 .
This includes multiple other changes which are required dependencies for backporting the pull request.
This was achieved by cherry-picking #14648, #15365, copying over these specific files from master branch, cherry-picking #16832 and resolving merge conflicts on the way.
These are the files that were copied over from master branch (license header was modified to match
JAVADOC_STYLE:Java 11 has cgroup v2 support since 11.0.16 with https://bugs.openjdk.org/browse/JDK-8230305 changes.
Documentation
docdoc-requireddoc-not-neededdoc-complete