-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][doc]Add introduction of transaction isolation level in the txn-advanced-features.md #712
Conversation
We should not merge this patch until PIP-298 is accepted and merged. Is it correct? |
[ci skip]
[ci skip]
[ci skip]
The PIP-298 has been merged: apache/pulsar#21114 I applied slight changes that shouldn't affect sense much: Merging. |
@visortelle Please make sure someone approves and all concerns are addressed before merging the PR. |
@shibd Who is "someone"? I'd prefer you name the list of component experts so that @visortelle can ping for review. Note that @visortelle is a committer and we don't have class among committers but if you know experts that should review changes on these components, we can collaborate. |
I just want to remind @visortelle that PRs should be reviewed by someone before they can be merged, and we should also take comments into consideration. |
@shibd ok, no problem. Let me know if something is wrong with this specific PR. |
Thanks, This PR should not be merged because it has not been implemented yet. Please refer to this comment: #712 (comment) |
I agree, it is my fault. I think it makes sense to:
@shibd WDYT? |
…txn-advanced-features.md (#712) * Add introduction of transaction isolation level in the txn-advanced-features.md Co-authored-by: Kiryl Valkovich <[email protected]>
|
…txn-advanced-features.md (#906) * [improve][doc]Add introduction of transaction isolation level in the txn-advanced-features.md (#712) * Add introduction of transaction isolation level in the txn-advanced-features.md Co-authored-by: Kiryl Valkovich <[email protected]> * Apply docs to versioned_docs after 3.2.x --------- Co-authored-by: hzh0425 <[email protected]> Co-authored-by: Lari Hotari <[email protected]>
This PR adds doc for apache/pulsar#21114
This PR fixes #xyz
doc
doc-required
doc-not-needed
doc-complete