Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zookeeper healthchecks compatible with Alpine's busybox nc #504

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jun 7, 2024

Motivation

The apachepulsar/pulsar:3.3.0 image contains busybox nc which doesn't support -q 1 command line option.
See apache/pulsar#22872.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

@lhotari lhotari self-assigned this Jun 7, 2024
@lhotari lhotari marked this pull request as draft June 7, 2024 15:04
- Alpine nc fails if "localhost" is used.
  - perhaps it defaults to use IPv6?
@lhotari lhotari marked this pull request as ready for review June 7, 2024 15:16
@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

There's some other issue with the Alpine image:

Server:        10.96.0.10
Address:    10.96.0.10:53

** server can't find pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar: NXDOMAIN

** server can't find pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar: NXDOMAIN

/etc/resolv.conf is

search pulsar.svc.cluster.local svc.cluster.local cluster.local 1evhaya2a4vu1idbbq22av5vmh.bx.internal.cloudapp.net
nameserver 10.96.0.10
options ndots:5

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

Some DNS config issue:

pulsar-ci-pulsar-init-pfdv8:/pulsar$ nslookup pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar.svc.cluster.local
Server:         10.96.0.10
Address:        10.96.0.10:53

Name:   pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar.svc.cluster.local
Address: 10.244.1.17


pulsar-ci-pulsar-init-pfdv8:/pulsar$ nslookup pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar
Server:         10.96.0.10
Address:        10.96.0.10:53

** server can't find pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar: NXDOMAIN

** server can't find pulsar-ci-zookeeper-0.pulsar-ci-zookeeper.pulsar: NXDOMAIN

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

found k3s-io/k3s#6561 (comment) , but not a proper resolution.

@lhotari
Copy link
Member Author

lhotari commented Jun 7, 2024

Looks like busybox nslookup isn't compatible. docker-library/busybox#48 (comment)

will need apk add bind-tools in Alpine image.

- the image needs "apk add bind-tools" since busybox nslookup isn't compatible with kubernetes
@lhotari lhotari merged commit 9db0ccc into apache:master Jun 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant