Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable functions by default in values.yaml #483

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Disable functions by default in values.yaml #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci/values-common.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ affinity:
components:
autorecovery: false
pulsar_manager: false
# enable functions by default in CI
functions: true

zookeeper:
replicaCount: 1
Expand Down
4 changes: 3 additions & 1 deletion charts/pulsar/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ components:
# broker
broker: true
# functions
functions: true
# WARNING! Before enabling functions, make sure that all of your users are trusted since functions run user code
# and the current security sandbox is not sufficient to protect against malicious code.
functions: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any documentation for function security that they could be pointed to?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No such documentation exists currently.

# proxy
proxy: true
# toolset
Expand Down
Loading