making .ReleaseIsInstall optional for init jobs #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-ba
changed the title
lhotari
reviewed
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479
Motivation
In solutions like ArgoCD which don't actually track helm state, .ReleaseIsInstall always evaluates to true. We should be able to optionally not use .ReleaseIsInstall to determine whether init jobs should be created/removed
Modifications
makes a new value
useReleaseStatuswhich defaults to true.When
useReleaseStatusis set to false, the chart relies only on the value of theinitializevalue to determine whether the init jobs should be created.This PR also changes an
orin the pulsar-manager-cluster-initialize template to anand. With theorin place, the value passed at.Values.job.ttl.enabledwas ignored for all clusters newer than Kubernetes version 1.23.0. This causes the job to be constantly recreated in argocd.Verifying this change