rbac toggles broker roles / rolebindings #453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are namespace level roles / rolebinding also prohibited? What is the cluster setting that prevents this? I'm aware that OpenShift and Tanzu are usually handled with namespace level permissions so ClusterRole/ClusterRoleBindings don't work. |
|
Yes. Our cluster settings prohibit everything role related (cluster or not). They can be created, but only from admin users. I'm unsure what the setting is but the provider is Rancher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the optional creation of roles/rolebinding for the broker. All other PSP-related resources were previously already toggleable, now broker is also toggleable.
However, I'm unsure if this has implications on the functionality of Pulsar as a whole.
Motivation
Some cluster settings prohibit the creation of roles/rolebindings (e.g. Rancher), therefore settings rbac.enabled = False should also prevent the creation of any of these resources.