Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace removed tolerate-unready-endpoints annotation with publishNotReadyAddresses #368

Closed
wants to merge 1 commit into from
Closed

Replace removed tolerate-unready-endpoints annotation with publishNotReadyAddresses #368

wants to merge 1 commit into from

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jul 10, 2023

Motivation

Pulsar helm chart isn't compatible with k8s 1.24+ since there isn't a way to configure Zookeeper service with publishNotReadyAddresses: true.

Modifications

  • set publishNotReadyAddresses: true for zookeeper service
  • remove traces of removed service.alpha.kubernetes.io/tolerate-unready-endpoints annotation

Verifying this change

  • Make sure that the change passes the CI checks.

@lhotari
Copy link
Member Author

lhotari commented Jul 10, 2023

I included this change in #370 since it was necessary to get the CI tests to pass.

@lhotari lhotari closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi Awaiting requested review from nicoloboschi

@michaeljmarshall michaeljmarshall Awaiting requested review from michaeljmarshall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lhotari