Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support batch receive for consumer. #357

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Dec 5, 2023

Master Issue: #274

Motivation

#274 Support batch receive for the consumer.

Modifications

  • Add batch receive policy config on the consumer.
  • Add batch receive interface on the consumer.
  • Refactor consumer config set and verify logic.
    • Since config set logic with verify logic for the consumer is separate, it will be more complicated to read the code and subsequent extensions.

Verifying this change

  • Add batch receive unit test on Consumer.
  • Add more config verify unit test on Consumer.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

src/ConsumerConfig.cc Show resolved Hide resolved
tests/consumer.test.js Show resolved Hide resolved
src/ConsumerConfig.h Outdated Show resolved Hide resolved
tests/consumer.test.js Show resolved Hide resolved
@BewareMyPower BewareMyPower merged commit 258241c into apache:master Jan 8, 2024
12 checks passed
@shibd shibd added this to the 1.10.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants